pharmaverse / ggsurvfit

http://www.danieldsjoberg.com/ggsurvfit/
Other
67 stars 19 forks source link

add multiple geoms with data args after ggsurvfit() #127

Closed ddsjoberg closed 1 year ago

ddsjoberg commented 1 year ago

When multiple data args are passed, we may not be grabbing the correct underlying data frame is being selected, resulting in an error

library(ggsurvfit)
#> Loading required package: ggplot2

p <- 
  survfit2(Surv(time, status) ~ 1, data = df_lung) %>%
  ggsurvfit() +
  add_confidence_interval()

tt <- 
  p +
  geom_point(data = mtcars, aes(y = mpg, x = hp))

ggsurvfit_build(tt)
#> Error in `.data$survfit`:
#> ! Column `survfit` not found in `.data`.

#> Backtrace:
#>      ▆
#>   1. ├─base::tryCatch(...)
#>   2. │ └─base (local) tryCatchList(expr, classes, parentenv, handlers)
#>   3. │   ├─base (local) tryCatchOne(...)
#>   4. │   │ └─base (local) doTryCatch(return(expr), name, parentenv, handler)
#>   5. │   └─base (local) tryCatchList(expr, names[-nh], parentenv, handlers[-nh])
#>   6. │     └─base (local) tryCatchOne(expr, names, parentenv, handlers[[1L]])
#>   7. │       └─base (local) doTryCatch(return(expr), name, parentenv, handler)
#>   8. ├─base::withCallingHandlers(...)
#>   9. ├─base::saveRDS(...)
#>  10. ├─base::do.call(...)
#>  11. ├─base (local) `<fn>`(...)
#>  12. ├─global `<fn>`(input = base::quote("choky-barb_reprex.R"))
#>  13. │ └─rmarkdown::render(input, quiet = TRUE, envir = globalenv(), encoding = "UTF-8")
#>  14. │   └─knitr::knit(knit_input, knit_output, envir = envir, quiet = quiet)
#>  15. │     └─knitr:::process_file(text, output)
#>  16. │       ├─base::withCallingHandlers(...)
#>  17. │       ├─knitr:::process_group(group)
#>  18. │       └─knitr:::process_group.block(group)
#>  19. │         └─knitr:::call_block(x)
#>  20. │           └─knitr:::block_exec(params)
#>  21. │             └─knitr:::eng_r(options)
#>  22. │               ├─knitr:::in_input_dir(...)
#>  23. │               │ └─knitr:::in_dir(input_dir(), expr)
#>  24. │               └─knitr (local) evaluate(...)
#>  25. │                 └─evaluate::evaluate(...)
#>  26. │                   └─evaluate:::evaluate_call(...)
#>  27. │                     ├─evaluate (local) handle(...)
#>  28. │                     │ └─base::try(f, silent = TRUE)
#>  29. │                     │   └─base::tryCatch(...)
#>  30. │                     │     └─base (local) tryCatchList(expr, classes, parentenv, handlers)
#>  31. │                     │       └─base (local) tryCatchOne(expr, names, parentenv, handlers[[1L]])
#>  32. │                     │         └─base (local) doTryCatch(return(expr), name, parentenv, handler)
#>  33. │                     ├─base::withCallingHandlers(...)
#>  34. │                     ├─base::withVisible(value_fun(ev$value, ev$visible))
#>  35. │                     └─knitr (local) value_fun(ev$value, ev$visible)
#>  36. │                       └─knitr (local) fun(x, options = options)
#>  37. │                         ├─base::withVisible(knit_print(x, ...))
#>  38. │                         ├─knitr::knit_print(x, ...)
#>  39. │                         └─knitr:::knit_print.default(x, ...)
#>  40. │                           └─evaluate (local) normal_print(x)
#>  41. │                             ├─base::print(x)
#>  42. │                             └─ggplot2:::print.ggplot(x)
#>  43. │                               ├─ggplot2::ggplot_build(x)
#>  44. │                               └─ggplot2:::ggplot_build.ggplot(x)
#>  45. │                                 └─ggplot2 (local) by_layer(function(l, d) l$compute_aesthetics(d, plot))
#>  46. │                                   └─ggplot2 (local) f(l = layers[[i]], d = data[[i]])
#>  47. │                                     └─l$compute_aesthetics(d, plot)
#>  48. │                                       └─ggplot2 (local) f(..., self = self)
#>  49. │                                         └─ggplot2:::scales_add_defaults(...)
#>  50. │                                           └─base::lapply(aesthetics[new_aesthetics], eval_tidy, data = data)
#>  51. │                                             └─rlang (local) FUN(X[[i]], ...)
#>  52. ├─survfit
#>  53. ├─rlang:::`$.rlang_data_pronoun`(.data, survfit)
#>  54. │ └─rlang:::data_pronoun_get(...)
#>  55. └─rlang:::abort_data_pronoun(x, call = y)
#>  56.   └─rlang::abort(msg, "rlang_error_data_pronoun_not_found", call = call)

Created on 2022-11-03 with reprex v2.0.2