pharmaverse / ggsurvfit

http://www.danieldsjoberg.com/ggsurvfit/
Other
67 stars 19 forks source link

Warning message in `add_risktable_strata_symbol()` forwards user to next warning message #129

Closed timtreis closed 1 year ago

timtreis commented 1 year ago

When calling add_risktable_strata_symbol() on a ggsurvfit object, it tells the user to call add_risktable() beforehand.

image

However, an inexperienced user will just add + add_risktable() to the command, which will inevitably trigger the next warning since it has to be called as + add_risktable(risktable_group='risktable_stats').

image

This is a tiny bit annoying and could be streamlined, by, for example, just including the required argument in the first thrown warning.

ddsjoberg commented 1 year ago

I like the suggestion! We'll get to it soon :)