pharmaverse / ggsurvfit

http://www.danieldsjoberg.com/ggsurvfit/
Other
67 stars 19 forks source link

Code Coverage #167

Closed ddsjoberg closed 9 months ago

ddsjoberg commented 9 months ago

we have 100% code coverage, but some of the vdiffr snapshot tests began failing on CI/CD but not locally. I asked Hadley Wickham about this and he suggested to just ignore, because the vidffr checks are very complicated and if everything is ok locally we shouldn't worry about it.

I think a little refactoring of the tests will be sufficient, e.g. just checking the test runs without error, then at the end of the check chunk we do all the vdiffr checks with the saved objects and we skip that on CI/CD