pharmaverse / ggsurvfit

http://www.danieldsjoberg.com/ggsurvfit/
Other
67 stars 19 forks source link

Allow users to switch between color and linetype aesthetics #172

Closed ddsjoberg closed 8 months ago

ddsjoberg commented 8 months ago

What changes are proposed in this pull request?

If there is an GitHub issue associated with this pull request, please provide link. closes #166


Reviewer Checklist (if item does not apply, mark as complete)

When the branch is ready to be merged into master:

psoldath commented 8 months ago

@ddsjoberg I download the pull request and the code works perfectly! Thank you for implementing the request.

ddsjoberg commented 8 months ago

Great! We'll merge this when @timtreis, a package co-author, has completed the review!

ddsjoberg commented 8 months ago

Thank you @timtreis for the thorough review!

vdiffr began failing everywhere (except locally) recently. I've since turned these off on GH Actions. I hope they begin working again. Previously, we had set to only run the vdiffr tests when the R version matched the current release of R and the check was being run on the same OS I develop on to avoid those kinds of failures on Linux.

I am sure if you looked at the differences in the failing vdiffr tests, there wouldn't be anything importantly different.