Closed ddsjoberg closed 8 months ago
@ddsjoberg I download the pull request and the code works perfectly! Thank you for implementing the request.
Great! We'll merge this when @timtreis, a package co-author, has completed the review!
Thank you @timtreis for the thorough review!
vdiffr began failing everywhere (except locally) recently. I've since turned these off on GH Actions. I hope they begin working again. Previously, we had set to only run the vdiffr tests when the R version matched the current release of R and the check was being run on the same OS I develop on to avoid those kinds of failures on Linux.
I am sure if you looked at the differences in the failing vdiffr tests, there wouldn't be anything importantly different.
What changes are proposed in this pull request?
ggsurvfit()
orggcuminc()
uses the color aesthetic to plot curves by the stratifying variable(s), and further,ggcuminc()
uses the linetype aesthetic for plots that contain multiple outcomes (i.e. competing events). We not introduce the global option"ggsurvfit.switch-color-linetype"
to switch these defaults, giving users more flexibility over the output figures. (#166)If there is an GitHub issue associated with this pull request, please provide link. closes #166
Reviewer Checklist (if item does not apply, mark as complete)
renv::install()
_pkgdown.yml
pkgdown::build_site()
. Check the R console for errors, and review the rendered website.withr::with_envvar(new = c("NOT_CRAN" = "true"), covr::report())
. Begin in a fresh R session without any packages loaded.usethis::use_spell_check()
runs with no spelling errors in documentationWhen the branch is ready to be merged into master:
NEWS.md
with the changes from this pull request under the heading "# ggsurvfit (development version)
". If there is an issue associated with the pull request, reference it in parentheses at the end update (seeNEWS.md
for examples).usethis::use_version(which = "dev")
codemetar::write_codemeta()
usethis::use_spell_check()
again