Closed avishaitsur closed 1 month ago
Thank you for the PR!! I will likely to get to this next week.
it looks like there are some test failures. can you take a look at the details?
FYI, I have just heard from the maintainer of the survival package that they are planning a release that has breaking changes in ggsurvfit. This means that I will prepping a new release soon. If you want to address the failures in the checks in the next week, we may be able to add this to the next release. Let me know if you have questions. Thanks, Daniel
Hi Daniel,
I'm a physician, and my coding/GitHub/package development skills are pretty basic. Despite my best efforts, I am struggling with the remaining test failures. I have managed to address some, but others are beyond my ability to resolve efficiently.
I'm reaching out to see if someone within the community could assist in refining these fixes. I believe the updates would be beneficial, especially for users conducting medical research. Any support or direction on how to move forward with these specific issues would be greatly appreciated.
Thank you again for your patience and for considering these modifications.
FYI I removed the call to ggplot2::scale_x_log10
because we were mixing log base e with log base 10. I added an example to the gallery using the correct base log.
What changes are proposed in this pull request? Add a
type = "cloglog"
for log minus log survival plots totidysurvfit()
andggsurvfit()
. These plots are widely used to assess the assumption of proportional hazards before running a Cox regression model and are implemented in thesurvival
andsurvminer
packages.If there is an GitHub issue associated with this pull request, please provide link. closes https://github.com/pharmaverse/ggsurvfit/issues/194
Reviewer Checklist (if item does not apply, mark as complete)
renv::install()
_pkgdown.yml
pkgdown::build_site()
. Check the R console for errors, and review the rendered website.withr::with_envvar(list(CI = TRUE), code = devtools::test_coverage())
. Begin in a fresh R session without any packages loaded.usethis::use_spell_check()
runs with no spelling errors in documentationWhen the branch is ready to be merged into master:
NEWS.md
with the changes from this pull request under the heading "# ggsurvfit (development version)
". If there is an issue associated with the pull request, reference it in parentheses at the end update (seeNEWS.md
for examples).usethis::use_version(which = "dev")
usethis::use_spell_check()
again