pharmaverse / ggsurvfit

http://www.danieldsjoberg.com/ggsurvfit/
Other
67 stars 19 forks source link

Add a `type = "cloglog"` for log minus log survival plots #195

Closed avishaitsur closed 1 month ago

avishaitsur commented 2 months ago

What changes are proposed in this pull request? Add a type = "cloglog" for log minus log survival plots to tidysurvfit() and ggsurvfit(). These plots are widely used to assess the assumption of proportional hazards before running a Cox regression model and are implemented in the survival and survminer packages.

If there is an GitHub issue associated with this pull request, please provide link. closes https://github.com/pharmaverse/ggsurvfit/issues/194


Reviewer Checklist (if item does not apply, mark as complete)

When the branch is ready to be merged into master:

ddsjoberg commented 2 months ago

Thank you for the PR!! I will likely to get to this next week.

ddsjoberg commented 2 months ago

it looks like there are some test failures. can you take a look at the details?

ddsjoberg commented 2 months ago

FYI, I have just heard from the maintainer of the survival package that they are planning a release that has breaking changes in ggsurvfit. This means that I will prepping a new release soon. If you want to address the failures in the checks in the next week, we may be able to add this to the next release. Let me know if you have questions. Thanks, Daniel

avishaitsur commented 2 months ago

Hi Daniel,

I'm a physician, and my coding/GitHub/package development skills are pretty basic. Despite my best efforts, I am struggling with the remaining test failures. I have managed to address some, but others are beyond my ability to resolve efficiently.

I'm reaching out to see if someone within the community could assist in refining these fixes. I believe the updates would be beneficial, especially for users conducting medical research. Any support or direction on how to move forward with these specific issues would be greatly appreciated.

Thank you again for your patience and for considering these modifications.

ddsjoberg commented 1 month ago

FYI I removed the call to ggplot2::scale_x_log10 because we were mixing log base e with log base 10. I added an example to the gallery using the correct base log.