The tidy_survfit() (and subsequently ggsurvfit()) now honor the survfit(start.time) if specified. (#192)
We now allow for negative follow-up times in tidy_survfit() (and subsequently ggsurvfit()). When negative follow-up times are present users should specify survfit(start.time) and we print a note to this effect when not set. (#192)
If there is an GitHub issue associated with this pull request, please provide link.
closes #192
Thank you @bethatkinson for the guidance on this update.
We now respect the start.time specification, and print a note about specifying start.time when there are negative times.
Reviewer Checklist (if item does not apply, mark as complete)
[x] Ensure all package dependencies are installed by running renv::install()
[x] PR branch has pulled the most recent updates from master branch. Ensure the pull request branch and your local version match and both have the latest updates from the master branch.
[x] If a new function was added, function included in _pkgdown.yml
[x] If a bug was fixed, a unit test was added for the bug check
[x] Run pkgdown::build_site(). Check the R console for errors, and review the rendered website.
[x] Overall code coverage remains >99.5%. Review coverage with withr::with_envvar(list(CI = TRUE), code = devtools::test_coverage()). Begin in a fresh R session without any packages loaded.
[x] R CMD Check runs without errors, warnings, and notes
[x] usethis::use_spell_check() runs with no spelling errors in documentation
When the branch is ready to be merged into master:
[x] Update NEWS.md with the changes from this pull request under the heading "# ggsurvfit (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (see NEWS.md for examples).
[x] Increment the version number using usethis::use_version(which = "dev")
What changes are proposed in this pull request?
The
tidy_survfit()
(and subsequentlyggsurvfit()
) now honor thesurvfit(start.time)
if specified. (#192)We now allow for negative follow-up times in
tidy_survfit()
(and subsequentlyggsurvfit()
). When negative follow-up times are present users should specifysurvfit(start.time)
and we print a note to this effect when not set. (#192)If there is an GitHub issue associated with this pull request, please provide link. closes #192
Thank you @bethatkinson for the guidance on this update.
We now respect the
start.time
specification, and print a note about specifyingstart.time
when there are negative times.Created on 2024-04-04 with reprex v2.1.0
Reviewer Checklist (if item does not apply, mark as complete)
renv::install()
_pkgdown.yml
pkgdown::build_site()
. Check the R console for errors, and review the rendered website.withr::with_envvar(list(CI = TRUE), code = devtools::test_coverage())
. Begin in a fresh R session without any packages loaded.usethis::use_spell_check()
runs with no spelling errors in documentationWhen the branch is ready to be merged into master:
NEWS.md
with the changes from this pull request under the heading "# ggsurvfit (development version)
". If there is an issue associated with the pull request, reference it in parentheses at the end update (seeNEWS.md
for examples).usethis::use_version(which = "dev")
usethis::use_spell_check()
again