pharmaverse / ggsurvfit

http://www.danieldsjoberg.com/ggsurvfit/
Other
72 stars 20 forks source link

fixed KMunicate legend position in gallery.Rmd #223

Open DanChaltiel opened 1 month ago

DanChaltiel commented 1 month ago

Hi,

As you can see in https://www.danieldsjoberg.com/ggsurvfit/articles/gallery.html#kmunicate, the legend is not inside the plot as it should be.

This is because the theme lacks legend.position="inside".

This very minor PR should fix it.


Reviewer Checklist (if item does not apply, mark as complete)

When the branch is ready to be merged into master:

ddsjoberg commented 1 month ago

Thank you so much @DanChaltiel ! Would you mind adding a snapshot test using vdiffr::expect_doppelganger() so we can ensure this doesn't break again in the future (I am pretty sure this worked before the ggplot2 3.5 release)