Open DanChaltiel opened 1 month ago
Thank you so much @DanChaltiel ! Would you mind adding a snapshot test using vdiffr::expect_doppelganger()
so we can ensure this doesn't break again in the future (I am pretty sure this worked before the ggplot2 3.5 release)
Hi,
As you can see in https://www.danieldsjoberg.com/ggsurvfit/articles/gallery.html#kmunicate, the legend is not inside the plot as it should be.
This is because the theme lacks
legend.position="inside"
.This very minor PR should fix it.
Reviewer Checklist (if item does not apply, mark as complete)
renv::install()
_pkgdown.yml
pkgdown::build_site()
. Check the R console for errors, and review the rendered website.withr::with_envvar(list(CI = TRUE), code = devtools::test_coverage())
. Begin in a fresh R session without any packages loaded.usethis::use_spell_check()
runs with no spelling errors in documentationWhen the branch is ready to be merged into master:
NEWS.md
with the changes from this pull request under the heading "# ggsurvfit (development version)
". If there is an issue associated with the pull request, reference it in parentheses at the end update (seeNEWS.md
for examples).usethis::use_version(which = "dev")
usethis::use_spell_check()
again