Open bms63 opened 6 months ago
@pharmaverse/admiral Hi all - Thinking that this will be a very useful part of our release process. I used the vanilla version of the usethis::release_issue()
and it made the issue on our GitHub Issues. However, I didn't find all the items very helpful.
Part of me is thinking - should it be broken into 3 issues? Pre-CRAN, Submit to CRAN, Post-CRAN. So the function would make three issues for us. I like smaller issues that we can close quickly. If we keep it as one issue, then it stays around until we finish every item :(
The checklist is not final. There are other things that are needed - just can't think of them at the moment. Post here if there is some missing checks that we should add!
Since admiraldev
is no longer going to be purged...I think we should put this there.
Feature Idea
The
usethis
package has arelase_issue()
function that produces an issue on the GitHub Repo with the following:Original Checklist
Prepare for release:
git pull
urlchecker::url_check()
devtools::check(remote = TRUE, manual = TRUE)
devtools::check_win_devel()
- doesn't work with Remtoesrhub::check_for_cran()
revdepcheck::revdep_check(num_workers = 4)
cran-comments.md
git push
Submit to CRAN:
usethis::use_version('major')
devtools::submit_cran()
Wait for CRAN...
git push
usethis::use_github_release()
usethis::use_dev_version()
git push
Some of these items in the checklist are not really helpful to us. However, we can customize this function to produce a scoped release issue for admiral.
Proposed New Checklist (TBD!!)
Prepare for release:
urlchecker::url_check()
devtools::check(remote = TRUE, manual = TRUE)
devtools::check_win_devel()
- doesn't work with Remtoesrhub::check_for_cran()
revdepcheck::revdep_check(num_workers = 4)
admiraldev
DESCRIPTION file, issues, etcSubmit to CRAN:
usethis::use_version('major')
devtools::submit_cran()
Wait for CRAN...
usethis::use_github_release()
usethis::use_dev_version()
Definition of Done
release_issue()
is created