pharmaverse / pharmaverseadam

Test ADaM data for use with pharmaverse
https://pharmaverse.github.io/pharmaverseadam
Apache License 2.0
12 stars 4 forks source link

closes #64 adding dataset logo #69

Closed sadchla-codes closed 5 months ago

sadchla-codes commented 5 months ago

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the devel branch until you have checked off each task.

kaz462 commented 5 months ago

@sadchla-codes Since the dataset documentation was generated by create_adams_data.R, could you help populate labels in "Datasets" sheet from the spec? I can add xportr::xportr_df_label to create_adams_data.R after the spec updates. Thank you!

sadchla-codes commented 5 months ago

@sadchla-codes Since the dataset documentation was generated by create_adams_data.R, could you help populate labels in "Datasets" sheet from the spec? I can add xportr::xportr_df_label to create_adams_data.R after the spec updates. Thank you!

Sure, I'll work on that