pharmaverse / pharmaverseadam

Test ADaM data for use with pharmaverse
https://pharmaverse.github.io/pharmaverseadam
Apache License 2.0
12 stars 4 forks source link

General Issue: Remove non-ASCII characters in the package ahead of any release #71

Closed manciniedoardo closed 4 months ago

manciniedoardo commented 5 months ago

Background Information

Non-ASCII characters cause NOTES to appear when running pre-release checks. We should remove any from the package to avoid any issues.

Definition of Done

sadchla-codes commented 4 months ago

Hi @manciniedoardo below is the result from running repo:pharmaverse/pharmaverseadam /[^\x00-\x7F]+/ do you want the following that are circle in red to be removed? image

manciniedoardo commented 4 months ago

Yes please, to be safe let's remove the fistbumps and replace the quotes with normal quotes (""). That way we have no non ascii chars anywhere in the package.