pharmaverse / pharmaversesdtm

Test SDTM data for use within the pharmaverse family of packages
https://pharmaverse.github.io/pharmaversesdtm
Apache License 2.0
13 stars 2 forks source link

Closes #56 eg program #114

Closed vbshuliar closed 1 month ago

vbshuliar commented 3 months ago

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the devel branch until you have checked off each task.

github-actions[bot] commented 3 months ago

Code Coverage

Package Line Rate Health
pharmaversesdtm 0%
Summary 0% (0 / 41)
manciniedoardo commented 2 months ago

Thanks @vbshuliar this is super 🚀

@kaz462 would you be able to give a second review here, including passing this version of eg into the admiral ADEG template to see if anything goes wrong? Then maybe we can get the NEST team to take a final look before we merge in.

manciniedoardo commented 2 months ago

Also not sure why the Man pages/Roxygen test keeps failing, i re-ran roxygenise() but no dice.

vbshuliar commented 2 months ago

Thank you very much for the opportunity to contribute to pharmaversesdtm and approving the pull request👌

manciniedoardo commented 2 months ago

@vbshuliar no problem. Actually can you make one last commit and add yourself to the DESCRIPTION file under authors?

manciniedoardo commented 2 months ago

@vbshuliar btw if you have an ORCID you can also add that to the description file.

kaz462 commented 2 months ago

@kaz462 would you be able to give a second review here, including passing this version of eg into the admiral ADEG template to see if anything goes wrong? Then maybe we can get the NEST team to take a final look before we merge in.

I passed this version of eg into the admiral ADEG template, everything is fine.

manciniedoardo commented 1 month ago

@vbshuliar can you work on this next week?

Additionally, if you merge main into your issue branch, it should fix the failing Roxygen check 😄