Closed vbshuliar closed 1 month ago
Package | Line Rate | Health |
---|---|---|
pharmaversesdtm | 0% | ❌ |
Summary | 0% (0 / 41) | ❌ |
Thanks @vbshuliar this is super 🚀
@kaz462 would you be able to give a second review here, including passing this version of eg
into the admiral ADEG template to see if anything goes wrong? Then maybe we can get the NEST team to take a final look before we merge in.
Also not sure why the Man pages/Roxygen test keeps failing, i re-ran roxygenise()
but no dice.
Thank you very much for the opportunity to contribute to pharmaversesdtm and approving the pull request👌
@vbshuliar no problem. Actually can you make one last commit and add yourself to the DESCRIPTION file under authors?
@vbshuliar btw if you have an ORCID you can also add that to the description file.
@kaz462 would you be able to give a second review here, including passing this version of
eg
into the admiral ADEG template to see if anything goes wrong? Then maybe we can get the NEST team to take a final look before we merge in.
I passed this version of eg
into the admiral ADEG
template, everything is fine.
@vbshuliar can you work on this next week?
Additionally, if you merge main
into your issue branch, it should fix the failing Roxygen check 😄
Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the
devel
branch until you have checked off each task.styler::style_file()
to style R and Rmd filesdevtools::document()
so all.Rd
files in theman
folder and theNAMESPACE
file in the project root are updated appropriatelyNEWS.md
if the changes pertain to a user-facing function (i.e. it has an@export
tag) or documentation aimed at users (rather than developers)pkgdown::build_site()
and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.lintr::lint_package()
R CMD check
locally and address all errors and warnings -devtools::check()