pharmaverse / pharmaversesdtm

Test SDTM data for use within the pharmaverse family of packages
https://pharmaverse.github.io/pharmaversesdtm
Apache License 2.0
13 stars 2 forks source link

Closes #88 Use pharmaversesdtm to host admiralpeds test data #115

Closed zdz2101 closed 3 weeks ago

zdz2101 commented 3 months ago

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the devel branch until you have checked off each task.

github-actions[bot] commented 3 months ago

Code Coverage

Package Line Rate Health
pharmaversesdtm 0%
Summary 0% (0 / 41)
manciniedoardo commented 3 months ago

Do we hold off on this until first release of admiralpeds?

rossfarrugia commented 3 months ago

Do we hold off on this until first release of admiralpeds?

Yes, it should be aligned with this update: https://github.com/pharmaverse/admiralpeds/issues/40. I'm just catching up from last week and looks like we had more review comments for admiralpeds and the team are working through them still so no CRAN submission as of yet...

rossfarrugia commented 2 months ago

@zdz2101 please let us know if you think this one is now ready for review given we've released admiralpeds to CRAN, and me and @Fanny-Gautier could take a look

zdz2101 commented 2 months ago

@zdz2101 please let us know if you think this one is now ready for review given we've released admiralpeds to CRAN, and me and @Fanny-Gautier could take a look

this is ready for review, the one on admiralpeds is to demonstrate it does work

rossfarrugia commented 2 months ago

@kaz462 @manciniedoardo @Fanny-Gautier appreciate if you could give this PR a sanity check too.

zdz2101 commented 1 month ago

@rossfarrugia @Fanny-Gautier This can be reviewed once again

zdz2101 commented 3 weeks ago

@kaz462 @manciniedoardo @rossfarrugia can we merge this? I'm getting a "restricts merging to authorized users"