Closed kaz462 closed 1 year ago
Following updates in this PR:
R/data.R
, dev
and data
folders from admiral.test
to admiraldata
git clone https://github.com/pharmaverse/admiral.test.git --branch devel --single-branch ./admiral.test --depth 1
cp -R ./admiral.test/data ./admiraldata
cp -R ./admiral.test/dev ./admiraldata
cp ./admiral.test/R/data.R ./admiraldata/R
rm -rf admiral.test
tests
folder
- Update/Remove the following files to use your extension name:
DESCRIPTION
File - Name, Authorsadmiraltemplate.Rproj
testthat.R
News.md
.Rbuildignore
.gitignore
.lycheeignore
_pkgdown.yml
devtools::document()
+ resolve workflow issues@kaz462 is it worth not copying the data in the
{admiral.test}
data folder and just regenerating it with the files that you copy over? Just to make sure that what you copied over genuinely makes the dataset that you expect?
I got some errors when I try to rerun the programs from admiral.test/dev
.
@manciniedoardo Should we merge this PR first, and create a separate issue for rerunning datasets (some programs need updates), so that we can work on other issues in parallel? - issue created
e.g., errors from dev/pp.R
-
> data("pc")
Warning message:
In data("pc") : data set ‘pc’ not found
>
> # Calculate subjects with all missing;
> blq_usubjid <- pc %>%
+ ungroup() %>%
+ group_by(STUDYID, DOMAIN, USUBJID) %>%
+ summarise(PPORRES = max(PCSTRESN, na.rm = TRUE))
>
> # Remove from PC, subjects with all blq (placebos);
> remove_usubjid <- blq_usubjid %>% filter(PPORRES == 0)
>
> pc1 <- anti_join(pc, remove_usubjid, by = c("STUDYID", "DOMAIN", "USUBJID"))
Error in `anti_join()`:
! Join columns in `y` must be present in the data.
✖ Problem with `STUDYID`, `DOMAIN`, and `USUBJID`.
Run `rlang::last_trace()` to see where the error occurred.
@pharmaverse/admiraldata If you are assigned to admiraldata
issues, please wait until this PR is merged
Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the
devel
branch until you have checked off each task.styler::style_file()
to style R and Rmd filesdevtools::document()
so all.Rd
files in theman
folder and theNAMESPACE
file in the project root are updated appropriatelyNEWS.md
if the changes pertain to a user-facing function (i.e. it has an@export
tag) or documentation aimed at users (rather than developers)pkgdown::build_site()
and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.lintr::lint_package()
R CMD check
locally and address all errors and warnings -devtools::check()