search

pharmaverse / pharmaversesdtm

Test SDTM data for use within the pharmaverse family of packages
https://pharmaverse.github.io/pharmaversesdtm
Apache License 2.0
13 stars 2 forks source link

General Issue: Add test data for admiralonco iRecist #32

Closed bundfussr closed 9 months ago

bundfussr commented 1 year ago

Background Information

Example data for the iRecist vignettes in admiralonco should be added: rs_onco_irecist.

Definition of Done

No response

bundfussr commented 1 year ago

You can easily create a tribble() call from the excel file by using the datapasta package. Copy a range of cells in the excel sheet and then call the "Paste as tribble" addin. image

I would exclude columns with constant values from the tribble() call and add them via a mutate() call. This should reduce the length of the lines a bit.

Thampi-hub commented 1 year ago

I created the tribble in a R-script using the datapasta like you suggested (not uploaded to Github yet). Do I store only this tribble R-script in the data folder? Also, wouldn't that be inconvenient to read the data afterwards?

Alternatively I would suggest we create 2 files: the tribble R-script and its output saved as a rda-file.

  1. The .rda data file could be saved in data folder.
  2. The tribble R-script can be saved in the data-raw folder (or anywhere else), in case the values had to be modified later. Let me know your thoughts on this!
bundfussr commented 1 year ago

Please store the data file in the data folder and the R script in the data-raw folder.

The data-raw folder was already created in the devel branch but after you have created your feature branch. So you need to merge devel into your feature branch to get it.

The R script should be named as the dataset, i.e., rs_onco_irecist.R.

Thampi-hub commented 1 year ago

Raised a new pull request with both files (rs_onco_irecist.R and rs_onco_irecist.rda) included.

kaz462 commented 10 months ago

@Thampi-hub @bundfussr are you planning to release it in Q4, 2023?

bundfussr commented 10 months ago

@Thampi-hub @bundfussr are you planning to release it in Q4, 2023?

Yes, we need it for the next admiralonco release.