Closed kaz462 closed 1 year ago
Summary of the updates:
dev
folder by data-raw
admiral_
in both programs and datasetsupdate_domain.R
programs to domain.R
ex/cm/sv/ts/vs/dm
(direct copy from CDISC pilot study)set.seed
in pc.R
/qs_ophtha.R
to avoid changes for future rerun@pharmaverse/admiraldata
I removed all raw_domain.rda
data, and updated to read them directly from the URL. Do you see any issues with this approach? should we save a copy of the raw data under data-raw
folder?
Thanks for working on this @kaz462 - there are a few things I would change in the individual scripts to make them tidier and more homogeneous, but as discussed yesterday for nowit's more important to get the package structure nailed down.
I removed all
raw_domain.rda
data, and updated to read them directly from the URL. Do you see any issues with this approach? should we save a copy of the raw data underdata-raw
folder?
I think that's OK because it is unlikely that the CDISC pilot data is removed or changed.
Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the
devel
branch until you have checked off each task.styler::style_file()
to style R and Rmd filesdevtools::document()
so all.Rd
files in theman
folder and theNAMESPACE
file in the project root are updated appropriatelyNEWS.md
if the changes pertain to a user-facing function (i.e. it has an@export
tag) or documentation aimed at users (rather than developers)pkgdown::build_site()
and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.lintr::lint_package()
R CMD check
locally and address all errors and warnings -devtools::check()