pharmaverse / pharmaversesdtm

Test SDTM data for use within the pharmaverse family of packages
https://pharmaverse.github.io/pharmaversesdtm
Apache License 2.0
13 stars 2 forks source link

Closes #26 rename/rerun programs from `admiral.test`/`admiralvaccine` #38

Closed kaz462 closed 1 year ago

kaz462 commented 1 year ago

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the devel branch until you have checked off each task.

kaz462 commented 1 year ago

Summary of the updates:

  1. replace dev folder by data-raw
  2. remove prefix admiral_ in both programs and datasets
  3. rename update_domain.R programs to domain.R
  4. add programs for ex/cm/sv/ts/vs/dm (direct copy from CDISC pilot study)
  5. add set.seed in pc.R/qs_ophtha.R to avoid changes for future rerun

@pharmaverse/admiraldata I removed all raw_domain.rda data, and updated to read them directly from the URL. Do you see any issues with this approach? should we save a copy of the raw data under data-raw folder?

manciniedoardo commented 1 year ago

Thanks for working on this @kaz462 - there are a few things I would change in the individual scripts to make them tidier and more homogeneous, but as discussed yesterday for nowit's more important to get the package structure nailed down.

bundfussr commented 1 year ago

I removed all raw_domain.rda data, and updated to read them directly from the URL. Do you see any issues with this approach? should we save a copy of the raw data under data-raw folder?

I think that's OK because it is unlikely that the CDISC pilot data is removed or changed.