pharmaverse / pharmaversesdtm

Test SDTM data for use within the pharmaverse family of packages
https://pharmaverse.github.io/pharmaversesdtm
Apache License 2.0
13 stars 2 forks source link

Closes #54 align terminology in data with get_terms() function #55

Closed zdz2101 closed 1 year ago

zdz2101 commented 1 year ago

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the devel branch until you have checked off each task.

github-actions[bot] commented 1 year ago

Code Coverage

Package Line Rate Health
pharmaversesdtm 0%
Summary 0% (0 / 41)
zdz2101 commented 1 year ago

Some context: the checks in https://github.com/pharmaverse/admiral/pull/2057 were failing because it was not able to fetch the admiral_smq_db and admiral_sdg_db using the get_terms() function which is to be expected with the removal of "admiral" in the name under data.R . By swapping out instances of "admiral" in the get_terms() function, it should resolve the previously mentioned pull request