Closed ramiromagno closed 7 months ago
Package | Line Rate | Health |
---|---|---|
sdtm.oak | 88% | ✔ |
Summary | 88% (241 / 273) | ✔ |
@ramiromagno, thanks so much for addressing Adam's and my comments 🙏
Everything looks awesome! I know that after the second approval you can merge, just wanted to make sure that at least one of our subject matter experts had a chance to try this awesomeness out. @rammprasad, will you have time?
Yes, I am reviewing it today. Lets merge it tomorrow.
Thank you so much for your feedback so far. I think we can still improve quite a bit the article about the create_iso8601()
function and add more units tests to get a good coverage. But perhaps getting some user feedback already would be useful too. Note that, as @rammprasad had suggested in one of our meetings, I changed the default value of .check_format
from TRUE
to FALSE
.
Hello @rammprasad: Just to be sure, I am only waiting for this pull request to be reviewed by you and then merged before I tackle these other two issues: #28 and #29. Is that okay?
Thank you, @ramiromagno, for merging this to the main. We can work on other issues (maybe #18 ) before #28 and #29
Hi @rammprasad : I was not the one to perform the merging :) It was Adam. But I am happy to address those three issues :)
Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the oak codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the
devel
branch until you have checked off each task.styler::style_file()
to style R and Rmd filesdevtools::document()
so all.Rd
files in theman
folder and theNAMESPACE
file in the project root are updated appropriatelyNEWS.md
if the changes pertain to a user-facing function (i.e. it has an@export
tag) or documentation aimed at users (rather than developers)pkgdown::build_site()
and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.lintr::lint_package()
R CMD check
locally and address all errors and warnings -devtools::check()
There is this NOTE: