Closed rammprasad closed 5 months ago
Package | Line Rate | Health |
---|---|---|
sdtm.oak | 88% | ✔ |
Summary | 88% (241 / 273) | ✔ |
@ramiromagno - One of the iso8601 test cases fail in the rcmd check PR. Will you be able to check the pipeline and take a look?
@ramiromagno - One of the iso8601 test cases fail in the rcmd check PR. Will you be able to check the pipeline and take a look?
Hello Ram, yes, I will look into it!
EDIT: Hi again Ram, I can't really see which are the fails. Could you provide the direct link to the workflow instance that generates the fail?
@kamilsi, @ramiromagno, thanks so much for your review and suggestions. Please note that I addressed couple of them in this PR and also opened https://github.com/pharmaverse/sdtm.oak/issues/38 to address the remaining in the future. I also added example SDTM CM datasets.
Please review/approve so that Ramiro can kindly proceed with derive
implementation.
Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the oak codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the
devel
branch until you have checked off each task.styler::style_file()
to style R and Rmd filesdevtools::document()
so all.Rd
files in theman
folder and theNAMESPACE
file in the project root are updated appropriatelyNEWS.md
if the changes pertain to a user-facing function (i.e. it has an@export
tag) or documentation aimed at users (rather than developers)pkgdown::build_site()
and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.lintr::lint_package()
R CMD check
locally and address all errors and warnings -devtools::check()