pharmaverse / sdtm.oak

An EDC and Data Standard agnostic SDTM data transformation engine that automates the transformation of raw clinical data in ODM format to SDTM based on standard mapping algorithms
https://pharmaverse.github.io/sdtm.oak/
Apache License 2.0
22 stars 6 forks source link

sdtm.oak SDTM spec, Algorithms Documentation and template r code for cm domain #30

Closed rammprasad closed 5 months ago

rammprasad commented 7 months ago

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the oak codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the devel branch until you have checked off each task.

github-actions[bot] commented 6 months ago

Code Coverage

Package Line Rate Health
sdtm.oak 88%
Summary 88% (241 / 273)
rammprasad commented 6 months ago

@ramiromagno - One of the iso8601 test cases fail in the rcmd check PR. Will you be able to check the pipeline and take a look?

ramiromagno commented 6 months ago

@ramiromagno - One of the iso8601 test cases fail in the rcmd check PR. Will you be able to check the pipeline and take a look?

Hello Ram, yes, I will look into it!

EDIT: Hi again Ram, I can't really see which are the fails. Could you provide the direct link to the workflow instance that generates the fail?

edgar-manukyan commented 5 months ago

@kamilsi, @ramiromagno, thanks so much for your review and suggestions. Please note that I addressed couple of them in this PR and also opened https://github.com/pharmaverse/sdtm.oak/issues/38 to address the remaining in the future. I also added example SDTM CM datasets.

Please review/approve so that Ramiro can kindly proceed with derive implementation.