pharmaverse / sdtm.oak

An EDC and Data Standard agnostic SDTM data transformation engine that automates the transformation of raw clinical data in ODM format to SDTM based on standard mapping algorithms
https://pharmaverse.github.io/sdtm.oak/
Apache License 2.0
22 stars 6 forks source link

0029 feedback create iso8601 #33

Closed ramiromagno closed 5 months ago

ramiromagno commented 7 months ago

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the oak codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the devel branch until you have checked off each task.

github-actions[bot] commented 7 months ago

Code Coverage

Package Line Rate Health
sdtm.oak 84%
Summary 84% (281 / 334)
ramiromagno commented 6 months ago

I have just integrated Adam's recent commits on the hyperlinks' update, and the Links Workflow is passing now :rocket:

So only the Test Coverage and the Roxygen workflows fail now: see issue https://github.com/pharmaverse/sdtm.oak/issues/35.

ramiromagno commented 5 months ago

Hello @rammprasad and @galachad:

Now that all checks are passing, could you review this PR now?

edgar-manukyan commented 5 months ago

@galachad, can we please get your blessing before we merge?