pharmaverse / sdtm.oak

An EDC and Data Standard agnostic SDTM data transformation engine that automates the transformation of raw clinical data in ODM format to SDTM based on standard mapping algorithms
https://pharmaverse.github.io/sdtm.oak/
Apache License 2.0
22 stars 6 forks source link

Adding a logomark/logotype #44

Closed ramiromagno closed 4 months ago

ramiromagno commented 4 months ago

New logo proposal. I've used an AI-generated simple watercolor of an oak branch and leaves, and made the leaves' hue inspired on CDISC's logomark colors, namely the colored dots. The dark blue of the outline and of the text is the same of CDISC's main dark blue. I think it looks nice and simple. Let me know your thoughts!

sdtm oak-wo-fonts

ramiromagno commented 4 months ago

Hi Kamil,

Thank you for your nice comments about the logo!

I haven't used any R code other than usethis::use_logo() (to place the logo in the right place). I have a long time ago developed my hex border with the right dimensions that I reuse for any new logo creation. So there isn't any special trick other than opening it in Inkscape and editing the logo to your liking and saving it. Then usethis::use_logo() takes the SVG file and places it where it needs to be.

So, if you want, you can just take this logo (see this PR's man/figures/logo.svg), open it in Inkscape and adapt it to your needs.

rammprasad commented 4 months ago

Hi @ramiro, Looks great. Can we make it green to match the OAK theme? Also, a simpler leaf will be better. I kind of managed to create this, but couldn't get the sdtm.oak inside the hexagon.

My first design

ramiromagno commented 4 months ago

Do you mean something like this?

sdtm oak_ramm

(I still prefer my own version :) )

rammprasad commented 4 months ago

Exactly, this is what I meant. We can even replace the oak leaf with an oak tree-like thing. Same problem in this one as well. I wasn't able to get the sdtm.oak inside the hex. Designer

rammprasad commented 4 months ago

Should we ask people to vote? lol

ramiromagno commented 4 months ago

Absolutely! After all this is open source :)

ramiromagno commented 4 months ago

As discussed in today's meeting I will merge the new logo into main.

github-actions[bot] commented 4 months ago

Code Coverage

Package Line Rate Health
sdtm.oak 86%
Summary 86% (349 / 408)
ramiromagno commented 4 months ago

@rammprasad : I think all requests have been addressed and we can merge this.