Closed ramiromagno closed 4 months ago
@edgar-manukyan: As discussed today, I will wait for those examples for inclusion in the Examples section of the docs and to create unit tests. Many thanks!
Package | Line Rate | Health |
---|---|---|
sdtm.oak | 68% | âž– |
Summary | 68% (498 / 734) | âž– |
@edgar-manukyan - Ready for your review.
Thanks so much Ramiro, looks fine to me. Just left two comments in case you want to address them. Are we going to add tests at some point?
I am happy to write the unit tests, but could you provide some input and output examples such that the tests are based on realistic examples, and also cover corner cases. (you guys have more experience here).
Thanks so much Ramiro, looks fine to me. Just left two comments in case you want to address them. Are we going to add tests at some point?
I am happy to write the unit tests, but could you provide some input and output examples such that the tests are based on realistic examples, and also cover corner cases. (you guys have more experience here).
Ram mentioned that we can have a separate issue to increase the coverage, no worries Ramiro. Thanks so much for your brilliant work 💠💠ðŸ’
Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the oak codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the
devel
branch until you have checked off each task.styler::style_file()
to style R and Rmd filesdevtools::document()
so all.Rd
files in theman
folder and theNAMESPACE
file in the project root are updated appropriatelyNEWS.md
if the changes pertain to a user-facing function (i.e. it has an@export
tag) or documentation aimed at users (rather than developers)pkgdown::build_site()
and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.lintr::lint_package()
R CMD check
locally and address all errors and warnings -devtools::check()