pharmaverse / sdtm.oak

An EDC and Data Standard agnostic SDTM data transformation engine that automates the transformation of raw clinical data in ODM format to SDTM based on standard mapping algorithms
https://pharmaverse.github.io/sdtm.oak/
Apache License 2.0
22 stars 6 forks source link

51 documentation updates v01 #56

Closed edgar-manukyan closed 3 weeks ago

edgar-manukyan commented 1 month ago

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the oak codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the devel branch until you have checked off each task.

github-actions[bot] commented 4 weeks ago

Code Coverage

Package Line Rate Health
sdtm.oak 88%
Summary 88% (786 / 894)
rammprasad commented 4 weeks ago

@edgar-manukyan @galachad @ramiromagno - I think all checks passed in the pipeline. But it is not showing up. Can you help me resolve this? From a content perspective, everything is complete.

ramiromagno commented 4 weeks ago

The DT package is in Suggests but should be in Imports because it's used in dataset_oak_vignette().

ramiromagno commented 4 weeks ago

Also, with R version 4.4 and more recent packages, I am also getting:

Using an external vector in selections was deprecated in tidyselect 1.1.0.
i Please use `all_of()` or `any_of()` instead.
  # Was:
  data %>% select(.after)

  # Now:
  data %>% select(all_of(.after))

These warnings come from the functions implemented in the branch with conditioned data frames, and I know I have fixed them before we merged into main. So I guess this branch does not yet have the most up-to-date version of main integrated into it...?

rammprasad commented 4 weeks ago

I have merged the latest main to this branch. Not sure what is going on. It doesn't show any differences.