search

pharmaverse / sdtm.oak

An EDC and Data Standard agnostic SDTM data transformation engine that automates the transformation of raw clinical data in ODM format to SDTM based on standard mapping algorithms
https://pharmaverse.github.io/sdtm.oak/
Apache License 2.0
25 stars 7 forks source link

derive_blfl - Address review comments #59

Open rammprasad opened 3 months ago

rammprasad commented 3 months ago 
          I have fixed a few minor items. Once this PR is approved, we can address the issues below.
  1. Refactor code based on suggestions - https://github.com/pharmaverse/sdtm.oak/pull/49#discussion_r1645492545 and https://github.com/pharmaverse/sdtm.oak/pull/49#discussion_r1645420117
  2. Validate the ISO date formats.
  3. Add test case and example for baseline_visit functionality (https://github.com/pharmaverse/sdtm.oak/pull/95)
  4. Address code issues based on suggestion - https://github.com/pharmaverse/sdtm.oak/pull/95#pullrequestreview-2288580679

Originally posted by @rammprasad in https://github.com/pharmaverse/sdtm.oak/issues/49#issuecomment-2179353596

rammprasad commented 2 months ago

I see this as an enhancement to the derive_blfl function; it can be addressed in the V0.2. I will not decouple this from the V0l1 release.

ramiromagno commented 2 months ago

Nice! Then I think we have all tasks ticked in https://github.com/pharmaverse/sdtm.oak/issues/65.