Closed ramiromagno closed 2 weeks ago
@rammprasad , @galachad, @edgar-manukyan, @kamilsi, @ShiyuC, @yli110-stat697: I'm sure this PR is going to raise a nice heated debate, and I think it would be best to do it in a meeting, but also think that have something concrete to discuss about is also helpful, so here it is this commit / PR, and a few extra notes for your consideration:
Note that I'm aware that many R packages using the Apache 2 License do not make any of these changes that I am proposing here. I think they are important nonetheless, and invite you to read:
Package | Line Rate | Health |
---|---|---|
sdtm.oak | 93% | ✔ |
Summary | 93% (953 / 1021) | ✔ |
Note that I'm aware that many R packages using the Apache 2 License do not make any of these changes that I am proposing here. I think they are important nonetheless, and invite you to read:
Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the oak codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the
devel
branch until you have checked off each task.styler::style_file()
to style R and Rmd filesdevtools::document()
so all.Rd
files in theman
folder and theNAMESPACE
file in the project root are updated appropriatelyNEWS.md
if the changes pertain to a user-facing function (i.e. it has an@export
tag) or documentation aimed at users (rather than developers)pkgdown::build_site()
and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.lintr::lint_package()
R CMD check
locally and address all errors and warnings -devtools::check()