Updated aerel check according to issue 255

pharmaverse / sdtmchecks

Analysis facing checks for SDTM data

https://pharmaverse.github.io/sdtmchecks/

Apache License 2.0

21 stars 8 forks source link

Updated aerel check according to issue 255 #259

Closed vrakinav closed 9 months ago

vrakinav commented 11 months ago

Fixed issue #255

harriscw commented 11 months ago

Thanks @vrakinav for taking a look. But not sure this gets at the heart of the issue.

I think the issue is more like line 130 expects 5 variables but the variable RAVE may or may not exist based on the study. I wonder if there's some logic that can be added to not hard code expected number of columns but instead operate on any AEREL* columns that exist. Let me know if that doesn't make sense

vrakinav commented 11 months ago

Hi Will. Thank you for the explanation. Now it should work. Please let me know if there is any other issue.

harriscw commented 11 months ago

Thanks @vrakinav for looking into this. It looks like with this update one of the unit tests is now failing. Can you rerun the unit tests (just run this code from R) and see why the test is failing? Thanks!

vrakinav commented 11 months ago

Hi Will. I found logic issue. Thank you for help.