search

pharmpy / modelbuilder

A GUI to build models using Pharmpy
BSD 2-Clause "Simplified" License
1 stars 2 forks source link

Make the "depot" default for transit models #129

Open rikardn opened 4 months ago

rikardn commented 4 months ago

I think this is the most natural first step if going to transits.

rikardn commented 4 months ago

At least when you have FO absorption.

antoniaih commented 4 months ago

Depot is set as default now for all types of absorption. Or should it only be default for FO absorption?

rikardn commented 4 months ago

I think we have another issue mentioning some combinations that we don't allow. For example ZO+transits and SEQ+transits.

antoniaih commented 4 months ago

Yes, SEQ+transits without depot gives an error. ZO+transits works.

antoniaih commented 4 months ago

I blocked ZO with 1 transit and SEQ-ZO-FO with transit without depot. But maybe this issue needs to be dicussed later.

rikardn commented 4 months ago

Ok. Yes I think we'll need to go through all cases for absorption rate and delay and what makes sense to not allow.