Update covariates when model structure changes

pharmpy / modelbuilder

A GUI to build models using Pharmpy

BSD 2-Clause "Simplified" License

1 stars 2 forks source link

Update covariates when model structure changes #136

Open antoniaih opened 3 months ago

antoniaih commented 3 months ago

Covariates need to be updated when the model structure is changed. If the user put a covariate on CL and then changes the model to Michaelis Menten elimination there is no CL parameter anymore and the program will crash. Covariates should be updated similarly to rvs in _update_rvs_from_model.

antoniaih commented 3 months ago

Fixed in https://github.com/pharmpy/modelbuilder/commit/001497f11d8e778ce964a7adcccc9e23a910838a

rikardn commented 3 months ago

This is a good point. I'll keep this open so we can double check how this works.