pharo-ai / decision-tree-model

Model for Decision Trees Learning in Pharo
MIT License
3 stars 1 forks source link

Why does decision tree dependes on DataFrame and Datasets? #6

Closed jordanmontt closed 1 year ago

jordanmontt commented 2 years ago

If you look at the baseline, it depends of dataFrame and Datasets. We should delete those dependencies

jecisc commented 1 year ago

Some part of the DecisionTree model seems to rely on the fact that the user gives a DataFrame.

For example: DtmDiscretizer>>#discretizableColumnsOf:

I'm not sure we really want that dependency, but if we want to remove it then we'll need to refactor the decision tree model before

jordanmontt commented 1 year ago

Yes agree, we need to refactor it to remove the dependency. After, we can add some extension methods in DataFrame if needed