Fixed metaRecursion for borderline cases

pharo-contributions / MethodProxies

A library to decorate and control method execution.

6 stars 7 forks source link

Fixed metaRecursion for borderline cases #19

Closed jordanmontt closed 3 months ago

jordanmontt commented 3 months ago

Changes

Added shared pool in class side ENABLE to enable and disable the instrumentation. This will allow to instrument the code and then to enable the instrumentation.
Simplified TrapMethod: Now, we don’t have the slow and fast deactivator. We have the same for all. This faciliates the handling of meta recursions. And regenerated the automatically generated prototypes methods.
Changed the API to separate the instrumentation with enabling the instrumentation

jordanmontt commented 3 months ago

Thanks @guillep for the changes!

Ducasse commented 3 months ago

I will ask some questions when I'm back :) The diff was long and I could not spot the changes to learn from.

jordanmontt commented 3 months ago

The diff was long because of the tonel v3 changes. Actually, the problem was in the deactivators. We had two deactivators (fast and slow). The fast was meant for optimizing, but it was difficult to handle properly the metarecursions. So how we decided to have only one handler for all cases