search

pharo-contributions / taskit

TaskIt is a library that ease Process usage in Pharo. It provides abstractions to execute and synchronize concurrent tasks, and several pre-built mechanisms that are useful for many application developers.
MIT License
43 stars 24 forks source link

Fix TKTConfiguration>>profile #71

Closed tinchodias closed 3 years ago

tinchodias commented 4 years ago

https://github.com/sbragagnolo/taskit/blob/master/TaskIt/TKTConfiguration.class.st#L86

tinchodias commented 4 years ago

I guess this method must answer self soleInstance value since 'profile:' sets the profile there:

TKTConfiguration>>
profile: aProfile
    self soleInstance basicValue ifNotNil: [ :p | p finalizeProfile ].
    self soleInstance value: aProfile.
    aProfile activateProfile

I will create a PR as my first contribution

tinchodias commented 4 years ago

Now I disconvered that defaultvalue (when value nil) is a TKTConfiguration, not a profile. This something to fix, right?

default
    | configuration |
    ^ value
        ifNil: [ self class profileNamed:TKTProfile defaultProfile.
            self assert: value isNotNil ]