TKTService>>restart: hard-coded delay of 500ms

pharo-contributions / taskit

TaskIt is a library that ease Process usage in Pharo. It provides abstractions to execute and synchronize concurrent tasks, and several pre-built mechanisms that are useful for many application developers.

MIT License

43 stars 24 forks source link

TKTService>>restart: hard-coded delay of 500ms #77

Closed tinchodias closed 3 years ago

tinchodias commented 4 years ago

TKTService>>
restart
    self stop.
    0.5 second wait.
    stopRequested := false.
    stopCallbacks := Set new.
    self start

The default stepDelay is 500ms too... stepDelay wait would be a replacement, but as stop answers a TKTFuture, waiting it to be completed sounds a better solution.

Also, it is strangely redefined in its subclass named TKTParameterizableService without this 500ms delay... I guess this redefinition should be removed.