search

pharo-graphics / Bloc

Low-level UI infrastructure & framework for Pharo
MIT License
80 stars 39 forks source link

Unifom class and trait prefixes? #111

Open tinchodias opened 3 years ago

tinchodias commented 3 years ago
  1. In Calypso, select Bloc package and open context menu, after "Inspect".
  2. In the inspector, click on raw ("a RPackage(Bloc)"), and inspect the result of: 
    self definedClasses reject:[ :each | each name beginsWith: 'Bl' ]

There are 26 classes/traits, in 3 big groups:

Moved from Brick? BrStencil BrStencilBuilder BrStencilDefaultExecutor BrStencilDynamicExecutor BrStencilExecutor BrStencilValuableExecutor BrValuableStencil

Traits, whose prefix should be BlT TBlAlignable TBlDebug TBlDirectionalLayout TBlElementCommonStyles TBlElementProperties TBlElementStyles TBlEventTarget TBlHostSpace TBlLayoutChildNode TBlLayoutNode TBlLayoutParentNode TBlNewLayoutCompositeNode TBlNewLayoutNode TBlNewLayoutNodeWithConstraints TBlSpaceProperties TBlTransformable

Other ManifestBloc <-- Okay AtomicSharedPriorityQueue SharedPriorityUniqueQueue

Ducasse commented 3 years ago

For traits I often use T first so for me I would keep them like that.

Ducasse commented 3 years ago

Do you mean that the BrStencil got moved to or should be moved to Brick?

Ducasse commented 3 years ago

BTW The trait renaming is not worth the changes and waves of updates.

tinchodias commented 3 years ago

Do we close/postpone this issue?

tinchodias commented 3 years ago

All the Br* seem plausible to be in Brick. I checked the references of each class and the only that looked non-trivial was BrValuableStencilwhich is referenced from TBlElementError>>#defaultErrorStencil in BlocPac.