Closed Enzo-Demeulenaere closed 1 month ago
Thanks. I think it's good to clean up. Also I see "gestures" mentioned in another property, probably not uses if it is related to touchpad-like gestures (I removed some unused gesture events hierarchy about a year ago).
In fact, I don't know what does it mean, the "dragboard". Google showed me a JavaFX's class.
Mhhmm. Who was discussing about drag&drop recently? @rvillemeur or @Nyan11? any opinion on this?
I checked in GToolkit, and the situation is the same as in Pharo. This variable is defined in BlSpace or BlBaseDragEvent, passed only through those 3 methods in BlMouseProcessor, without any usage. I suppose it was a half-implemented idea. I didn't experience a difference in drag&drop after removing all reference to it. @Enzo-Demeulenaere, I think you could also remove it from BlBaseDragEvent
You are right @rvillemeur I didn't see it in BlBaseDragEvent
I don't know about gestures but I see that BlBaseDragEvent
"gestureSource" instvar is used only in getter and setter, setter is called in the methods I showed earlier but also in 2 other methods while the getter has no senders, should I remove it ?
Same situation with "gestureTarget" instvar
I noticed this variable that is passed to every event but is never defined so every event just gets a nil variable for nothing, I simply removed it