search

pharo-graphics / Bloc

Low-level UI infrastructure & framework for Pharo
MIT License
80 stars 40 forks source link

Rescue ducasse example cleanup #577

Closed tinchodias closed 1 month ago

tinchodias commented 1 month ago

@Ducasse I recovered commits from your branch: https://github.com/pharo-graphics/Bloc/tree/2023-10--02-lessExamples

I had to resolve conflicts. And I avoided the commit on animations because I have changes on it.

If you agree, you merge this and delete the original branch

tinchodias commented 1 month ago

:-/ my conflict-solving changes introduced a compilation error 


*** Warning: Warning: The following definitions had errors while loading.  Press Proceed to try to load them again (they may work on a second pass):
  BlGeometryVisualAndLayoutBoundsTestOld

Syntax Error on line 4: 'End of statement expected'
===================================================
01: testAlignedIcon
02: 
03:     | anIconElement aLabelElement aContainerElement |
04:     anIconElement := self testEmptyIconElement geometry:
                  _^_
05:                          self testTrianglePolygon.
06:     aLabelElement := self testTextElementWithRunText.
07:     aContainerElement := self testIconAndTextContainer.
08:     aContainerElement addChildren: {
09:             anIconElement.
10:             aLabelElement }.
11:     ^ aContainerElement
CodeError:RBSyntaxErrorNotice UndefinedObject>>#DoIt 84:End of statement expected->testAlignedIcon
Ducasse commented 1 month ago

Tx martin!

Ducasse commented 1 month ago

This is strange I do not get why we would have a syntax error