554 tests are broken! - Githubissues

pharo-graphics / Toplo

A widget framework on top of Bloc

MIT License

19 stars 9 forks source link

554 tests are broken! #185

Closed Ducasse closed 2 months ago

Ducasse commented 3 months ago

We have 554 tests broken

Can we have a real process?
Did I integrate something wrong?
There is one event that does exist anymore
Can we learn from this?

eventsToHandle

    ^ {
          ToLayoutDirectionChangedEvent.
          ToLayoutOrientationChangedEvent.
          BlLayoutConstraintsChangedEvent }

Ducasse commented 3 months ago

I do not get it the GH action are green.

Ducasse commented 3 months ago

I could not find what removed BlLayoutConstraintsChangedEvent from Bloc. It is ok to remove it?

Ducasse commented 3 months ago

I was loading the master branch of Toplo no idea if this is good.

Ducasse commented 2 months ago

@tinchodias Hi martin why this issue is still open. I will fix it but I do not really get it. Having green tests is super important.

Ducasse commented 2 months ago

Broken tests were in master but they are green in dev. So after merging dev into master it will be ok

tinchodias commented 2 months ago

I missed the notification since last week. So I see you are doing a big pass, probably pair-programming with Alain, right? I see #190

Ducasse commented 2 months ago

Yes. I want to have a green bar and also make sure that we have smoke tests for all the examples. Check what I did in Toplo-Examples.