search

pharo-graphics / Toplo

A widget framework on top of Bloc
MIT License
19 stars 9 forks source link

Remove classes and methods tha are deprecated #204

Closed tinchodias closed 2 months ago

tinchodias commented 2 months ago

Fixes #203

tinchodias commented 2 months ago

CI shows this error:

UndeclaredVariableRead: Attempt to read undeclared variable ToChoiceMenu
UndeclaredVariable>>runtimeUndeclaredReadInContext:
ToChoiceMenuInSpaceTest>>testChoiceItemRightLabelAlignmentOnFirstPopup ...ToChoiceMenu
ToChoiceMenuInSpaceTest(TestCase)>>performTest

In 26 tests:

ToChoiceMenuInSpaceTest
 ✗ #testChoiceItemRightLabelAlignmentOnFirstPopup (12ms)
 ✗ #testWithStructuredDataWithWeakStrategy (4ms)
 ✗ #testWithStructuredDataWithWeakStrategy (2ms)
 ✗ #testWithStructuredDataWithStrictStrategy (3ms)
 ✗ #testWithStructuredDataWithStrictStrategy (4ms)
 ✗ #testChoiceItemRightLabelAlignmentOnFirstPopup (6ms)

ToChoiceMenuTest
 ✗ #testSelectedData1 (1ms)
 ✗ #testCheckUncheckWithUncheckStrategy (2ms)
 ✗ #testWithStrictStrategy (2ms)
 ✗ #testNoSelectedDataWithDefaultLabel (2ms)
 ✗ #testTryNoSelectedDataWithStrictStrategy (3ms)
 ✗ #testRemoveWithStrictStrategy (3ms)
 ✗ #testSelectedData2 (1ms)
 ✗ #testRemoveWithSeparator (3ms)
 ✗ #testWithWeakStrategy (2ms)
 ✗ #testDefaultLabel2 (1ms)
 ✗ #testWithOneStringData (1ms)
 ✗ #testEmpty (0ms)
 ✗ #testDefaultLabel3 (2ms)
 ✗ #testNoSelectedData (1ms)
 ✗ #testRemoveWithSeparator2 (3ms)
 ✗ #testRemoveWithStrictUncheckingStrategy (3ms)
 ✗ #testRemove (3ms)
 ✗ #testdefaultLabel (1ms)
 ✗ #testWith5StringData (2ms)
 ✗ #testAddRemoveOneStringData (2ms)
tinchodias commented 2 months ago

I think: Let's redo this change right after v0.2.0, and users depending on master will have time to upgrade code.