Replace BLRBTextStyler by Shout

pharo-graphics / Toplo

A widget framework on top of Bloc

MIT License

17 stars 8 forks source link

Replace BLRBTextStyler by Shout #88

Open jecisc opened 5 months ago

jecisc commented 5 months ago

It would be nice to use the text styler of Pharo instead of having one specific to Album to reduce duplication and the need to maintain two stylers. (Alain agreed)

tinchodias commented 2 months ago

Are you interested on this task @jecisc ?

jecisc commented 2 months ago

I tried to do it already but examples using syntax highlight were broken so and I did not know Toplo enough to do the change "in the dark".

I'm interested to do it but I don't have the time right now and I'll have a few weeks of holidays soon

tinchodias commented 1 hour ago

The deprecation message in the trait that BlRBTextStyler uses, suggests creating a subclass of RBProgramNodeVisitor. Is this the Shout solution?

tinchodias commented 1 hour ago

Okay, I wrote too fast: immediately I've found SHRBTextStyler

tinchodias commented 34 minutes ago

The main particularity I detect when I read the code of BlRBTextStyler in reference to SHRBTextStyler is creating instances in the hierarchy of BlTextLinkAttribute. But, as you can see in the screen capture... this hierarchy is stub, it does nothing special; it ignores the names it receives: