search

pharo-nosql / mongotalk

A Pharo driver for MongoDB
MIT License
19 stars 13 forks source link

Fix #mongo3CollectionNames to list beyond firstBatch #29

Closed tinchodias closed 5 years ago

tinchodias commented 6 years ago

Bug introduced with #27 workaround

noha commented 5 years ago

What is the status of this?

tinchodias commented 5 years ago

It isn't fixed (just checked).

OT: I read in a voyage's issue about dropping support for mongodb<3.4. If we do it also in this driver, we could simplify this implementation too... e.g.:

collections
    "Answer the collections in this database"

    | collectionNames |
    collectionNames := root majorVersion < 3
        ifTrue: [ self mongo2CollectionNames ]
        ifFalse: [ self mongo3CollectionNames ].
    ^ collectionNames
        collect: [:each | MongoCollection database: self name: each ]

(But this is OT, the issue will remain)

noha commented 5 years ago

We dropped support for mongo <3.4 so you can remove that code.

tinchodias commented 5 years ago

I created #48.

noha commented 5 years ago

To be honest I try to get rid of issues. Why did you create a new one?

tinchodias commented 5 years ago

48 was clean up issue, this is a bug. I created this issue as a "todo", to recall that if somebody has a database with many collections will get only a part of them as answer to #collections.