in VOSeedVersionGenerator >> #newVersion method throws DNU

pharo-nosql / voyage

Voyage is an object persistence abstraction layer for Pharo.

MIT License

33 stars 21 forks source link

Closed CafeKrem closed 4 years ago

CafeKrem commented 4 years ago

newVersion
    ^ UUIDGenerator new makeSeed

UIIDGenerator DoesNotUnderstand on Pharo 7 and Pharo 8

noha commented 4 years ago

Yes, that's why there is on the class side isDefault "In versions >= 5, we prefer VOMongoishVersionGenerator" ^ SystemVersion current major < 5

tinchodias commented 4 years ago

To clean up we could consider that from now there are no users of Voyage in Pharo 4 or less and do something about this code... remove the class?

noha commented 4 years ago

Right! We decided to support down to pharo6. So this is deprecated. Can you provide a PR?

CafeKrem commented 4 years ago

yes , I will do it