search

pharo-nosql / voyage

Voyage is an object persistence abstraction layer for Pharo.
MIT License
33 stars 21 forks source link

VOMongoRepository InstanceVariable host & port are unuse #156

Closed CafeKrem closed 4 years ago

CafeKrem commented 4 years ago

I think we should remove those 2 IVs and add methods to get those data from the IV mongoUrls.

What do you think ?

noha commented 4 years ago

I think you are right. They were used in the past but I guess when @tinchodias added the replica support he changed it to use mongo urls and so the instVars not needed anymore. Can you provide a pull request?

noha commented 4 years ago

And if the commit message contains "Fixes #156" it will close this issue when merged

CafeKrem commented 4 years ago

Yes I will do.