search

pharo-project / pharo-launcher

Lets you manage your pharo images and download new ones
https://pharo-project.github.io/pharo-launcher/
MIT License
109 stars 46 forks source link

VM Update to handle "url not found" error #431

Closed bencoman closed 4 years ago

bencoman commented 4 years ago

I had skipped a few notices that an update was available since I was in the middle of some development and wanted things static for a while. Now having time to update the VMs, I opened the VM panel and clicked "Update" image

and got an error straight away... image

The "errors" variable from context on second line shows...

"a CollectionValueHolder[ an OrderedCollection(
'https://files.pharo.org/get-files/old/pharo-win-stab...et-files/old/pharo-win-stable.zip'
'https://files.pharo.org/get-files/old/pharo-win-stable.zip') ]"

Trying the url "https://files.pharo.org/get-files/old/pharo-win-stable.zip" directly in a browse shows file doesn't exist, and indeed neither does "https://files.pharo.org/get-files/old/"

So myself I'm easily able to work around this by ignoring the first entry, but contributing factors to a poor UI experience for newcomers. a) Unhandled "missing file" exception - its reasonably common for files to be missing so this is not an error in the code, so should be handled mroe friendly. b) "old" is on the first line, so users don't get a chance to see to see a success before the failure.

So I will try attending to a), but btw also what should be done about b) ?

demarey commented 4 years ago

https://github.com/pharo-project/pharo-launcher/commit/0036b22f022bbf3b49a2804effad21d8c017a361 is also related.

The issue is solved but with a less nice ui. We could try to improve it by using a SpLinkPresenter in the PhLRetryPresenter.