pharo-project / pharo-launcher

Lets you manage your pharo images and download new ones
https://pharo-project.github.io/pharo-launcher/
MIT License
108 stars 46 forks source link

Launcher > 1.x no longer has shortcut keys for navigation (e.g. filter image) #499

Open timm-mwp opened 3 years ago

timm-mwp commented 3 years ago

Describe the bug Previous versions of Pharo Launcher had keboard shorcuts so that you could easily (via the keyboard) navigate the UI to filter images - tab to the images list and then press enter to launch the selected image. This no longer works in PL2.x

To Reproduce Steps to reproduce the behavior:

  1. Launch Pharo launcher (with a few images already downloaded)
  2. Try to navigate to the "enter image name to filter" text box without using your mouse
  3. If you get to the filter text box (currently have to click on it) - enter "8.0" (or some unique text), now tab to the image list (this works, but if you tab again you are stuck). If you realise the list is selected, you can press down arrow to enter the list (its very subtle - but at least works - and I believe 1.x was like this too)
  4. Use the arrow keys to move to the image you want to luanch, and then press enter to launch it (nothing happens - this no longer works in 2.x)

Expected behavior

Screenshots N/A

Version information:

Expected development cost ~1 day - should have been carried over from 1.x as this work was done in it. May have implicatations that Spec2 doesn't support keyboard mnemonics?

Additional context Look at how the 1.x launcher works

demarey commented 3 years ago

Thanks for the report. I did a commit with some fixes:

Mnemonics are not implemented in spec2 - morphic so I cannot use it. Navigation though tab / shift-tab works but the description text area eats tabs. So when you are on it, no way to escape ... I have no solution for this point.

Let me know if the new version is usable for you: https://ci.inria.fr/pharo-ci-jenkins2/job/PharoLauncher-Pipeline/job/dev/124/

PharoLauncher-Pipeline » dev #124 [Jenkins]