search

pharo-project / pharo-launcher

Lets you manage your pharo images and download new ones
https://pharo-project.github.io/pharo-launcher/
MIT License
109 stars 46 forks source link

Show folder button is broken in Windows 10 #551

Closed fuhrmanator closed 2 years ago

fuhrmanator commented 2 years ago

Describe the bug Clicking on the Show folder button for an image fails in PL 3.0 - this is a very useful feature in Windows but it now throws a Instance of Win64Platform did not understand #privShellExplore: error.

To Reproduce Steps to reproduce the behavior:

  1. Running PL in Windows 10, Select an image
  2. Click on the Show (folder) button (icon): image
  3. See error

Expected behavior Show the folder of the image in the OS (this feature worked fine in PL 2.x, it's a regression)

Screenshots image

Version information:

Expected development cost Unknown, but regressions with different OS could be tested in CI. Windows is a popular platform with end users, even if the devs prefer Linux and MacOS.

demarey commented 2 years ago

@fuhrmanator this kind of feature is very hard to test => interaction with the operating system. The only thing that could be tested is that there is no error on instance side. It is done in a command test but tests are, for now, only ran on linux. Only a few tests are impacted by the OS and I'm not sure it worths to run tests on all OS/arch combinations.