Use own list of source templates for testing pursposes to prevent missing template

pharo-project / pharo-launcher

Lets you manage your pharo images and download new ones

https://pharo-project.github.io/pharo-launcher/

MIT License

108 stars 46 forks source link

Use own list of source templates for testing pursposes to prevent missing template #555

Closed Bajger closed 2 years ago

Bajger commented 2 years ago

fixes #552
added sources list test setup and restore of original template list

Bajger commented 2 years ago

@demarey: Hi Christophe! Can you trigger CI for this PR? It seems that is is not running automatically.

demarey commented 2 years ago

Hi David, Here is the CI log for this PR: https://ci.inria.fr/pharo-ci-jenkins2/job/PharoLauncher-Pipeline/view/change-requests/job/PR-555/2/console

PharoLauncher-Pipeline » PR-555 #2 Console [Jenkins]

Bajger commented 2 years ago

Hi it is hard to determine, if some tests passed or not:

Ran [1;36m4[0m tests.

[1;31mFAILED[0m ([1;31mfailures=1[0m)

How can be this fixed? Any idea?

Bajger commented 2 years ago

It seems: there is something wrong with the startup of image:

testLauncherKillAllCommandWithOneImageLaunchedShouldKillAll
WARN: 

Assertion failure at SDL_CreateTexture_REAL (/home/travis/build/OpenSmalltalk/opensmalltalk-vm/build.linux64x64/third-party/SDL2-2.0.7/src/render/SDL_render.c:498), triggered 1 time:
  'renderer && renderer->magic == &renderer_magic'

Abort/Break/Retry/Ignore/AlwaysIgnore? [abriA] : [1;31mASSERT:[0mActual: "16138 /builds/Pharo/vms/100-x64/lib/pharo --headless /tmp/pharo-launcher-tests-launch-image-command.c16e04f7-a39a-0d00-a996-1a4809235d18/PharoLauncher.image --no-quit 16166 /builds/Pharo/vms/100-x64/lib/pharo --headless /tmp/pharo-launcher-tests-launch-image-from-disk-command.f39129f7-a39a-0d00-a99b-9f3009235d18/PharoLauncher.image --no-quit", expected: "PhLTestImage". Not found:<PhLTestImage>

demarey commented 2 years ago

Hi it is hard to determine, if some tests passed or not:
Ran �[1;36m4�[0m tests.

�[1;31mFAILED�[0m (�[1;31mfailures=1�[0m)
How can be this fixed? Any idea?

@Bajger I fixed it in https://github.com/pharo-project/pharo-launcher/commit/a28d85bb0785ad3fcb4478cba71e7f4f194eea64

demarey commented 2 years ago

I also fixed a pb in shunit2 that run oneTimeTearDown() twice for the last test (see https://github.com/pharo-project/pharo-launcher/commit/3a7072211ad8c0c07d770c40c796035d5182f1ec)

Bajger commented 2 years ago

@demarey PR looks ok now, CI tests green, output of Shunit tests looks fine. You can squash & merge now!