search

pharo-project / pharo-launcher

Lets you manage your pharo images and download new ones
https://pharo-project.github.io/pharo-launcher/
MIT License
109 stars 46 forks source link

Fix cleanup of PhLProcessWrapperTest>>testRunningInfiniteProcessThrowsTimeout #558

Closed Bajger closed 10 months ago

Bajger commented 2 years ago

Describe the bug PhLProcessWrapperTest>>testRunningInfiniteProcessThrowsTimeout starts infinite loop process, which is never terminated. Tests passes, but never cleans a process, which is still running. This causes noisy Hit CTRL+C output, when running multiple tests.

To Reproduce Steps to reproduce the behavior:

  1. Clone Pharo Launcher
  2. build pharo launcher: PHARO=100 ARCHITECTURE=64 ./build.sh prepare
  3. run: ./pharo-vm/pharo --headless ./PharoLauncher.image test "PharoLauncher-Tests-Functional"
  4. Hit CTRL+C keeps repeating on terminal (caused by testRunningInfiniteProcessThrowsTimeout)

Expected behavior Endless loop process is properly terminated after assertion (see test method).

Version information:

Expected development cost Add to test process terminate in ensure: block?

Bajger commented 2 years ago

@demarey : Should I remove my commit to not interfere with yours? https://github.com/Bajger/pharo-launcher/commit/7307b2215fb54a4d7627002f8b8d5bad3690ce93

Bajger commented 2 years ago

Ahh, ignore this PR is already closed.

Bajger commented 2 years ago

@demarey Should I close this issue? I think fix is only in feature/cmd-line branch, not sure if to cherrypick your fix to main branch?

demarey commented 2 years ago

the issue will close by itself when the cmd-line branch will be merged in the main branch