search

pharo-project / pharo-launcher

Lets you manage your pharo images and download new ones
https://pharo-project.github.io/pharo-launcher/
MIT License
109 stars 46 forks source link

Feature/cmd line create image from PR #563

Closed Bajger closed 2 years ago

Bajger commented 2 years ago

Changes need some more unit tests for extension methods, but command functionality is unit tested. Image creating is divided into following: image create -- this is based on template name, if not specified latest stable is used. Image name is mandatory positional. image create fromBuild uses build nr. image create fromPR uses pull request nr to ideintify correct build artifact from Inria CI image create fromSHA uses commit SHA 7 letter string to identify template image create fromRepo creates image based on template and downloads project by MC load command. (17-Jun: completed!)

All commands except last one are working.

Bajger commented 2 years ago

@demarey : Please check, why arm tests fail. It seems to be unrelated to changes. Other platform tests seems to be ok: https://ci.inria.fr/pharo-ci-jenkins2/job/PharoLauncher-Pipeline/job/feature%252Fcmd-line-create-image-from-PR/8/

PharoLauncher-Pipeline » feature/cmd-line-create-image-from-PR #8 [Jenkins]
demarey commented 2 years ago

PhLImageCreateFromRemoteRepoCliCommand and PhLImageCreateFromRemoteRepoCliCommand are missing a class comment

Bajger commented 2 years ago

@demarey Changes looks good to me, can we merge it? Or you want to take another look?