search

pharo-project / pharo-launcher

Lets you manage your pharo images and download new ones
https://pharo-project.github.io/pharo-launcher/
MIT License
108 stars 46 forks source link

Using "Show in folder" gives DNU #568

Closed astares closed 2 years ago

astares commented 2 years ago

When you use "Show in folder" from the context menu in the images list on Windows 10 it gives a DNU:

image

astares commented 2 years ago

The problem is that these methods are implemented on Win32Platform and are not available to class Win64Platform

image

I guess we need to move them to superclass WinPlatform or use a call to "ShellExecuteW" for Win64.

This is already a problem that need to be fixed in underlying Pharo platform - not really a problem of Launcher itself.

astares commented 2 years ago

Quick and dirty workaround: moving the two method to WinPlatform solved the issue.

astares commented 2 years ago

It had been solved already here: https://github.com/pharo-project/pharo-launcher/commit/dbca063906ec8fc7443eaf2492488692d0988fad

BUT:

The launcher should better use the method #openInOSFileBrowser on a file refernence in newer Pharo versions.

Example:

FileSystem workingDirectory openInOSFileBrowser