search

pharo-project / pharo-launcher

Lets you manage your pharo images and download new ones
https://pharo-project.github.io/pharo-launcher/
MIT License
109 stars 46 forks source link

Ctrl+X tries to delete a non-exixtent image #586

Open NSUSpray opened 1 year ago

NSUSpray commented 1 year ago

It is not possible to delete the selected image from the list of images using keyboard shortcut: instead of the file name of the selected image, the name myNewImage is mistakenly used.

To Reproduce

  1. Select any image in the image list
  2. Press the Ctrl+X shortcut
  3. See the confirmation popup “Are you sure you want to delete myNewImage”
  4. Confirm by pressing the “Yes” button
  5. See error “FileDoesNotExistException: '../Pharo/images/myNewImage'”

Expected behavior The behavior should be the same as when deleting an image with the mouse: the name of the selected image must be used instead of myNewImage.

myNewImage

Version information:

demarey commented 1 year ago

Thank you for the report. I tested both on OS X and Ubuntu but I cannot reproduce the problem. I just discovered the shortcut was not working properly on OS X. I will fix that. Maybe you could test the upcoming version and check if the problem is still there?

demarey commented 1 year ago

could be related to 1508c3ad88e6948d83282ef8af5b3c9c11dfa382

NSUSpray commented 1 year ago

I tried your suggestion: added the lines of this commit to the working launcher image and I recompiled this methods, but the problem remains. Do I need to apply the changes in any additional way?

demarey commented 1 year ago

you can test with the bundles available at https://ci.inria.fr/pharo-ci-jenkins2/job/PharoLauncher-Pipeline/job/dev/197/ but I fear you will get the same result. Tell me

PharoLauncher-Pipeline » dev #197 [Jenkins]