pharo-project / pharo-launcher

Lets you manage your pharo images and download new ones
https://pharo-project.github.io/pharo-launcher/
MIT License
109 stars 46 forks source link

Scripts to run Pharo Launcher aren't executable by default #641

Closed Bajger closed 10 months ago

Bajger commented 10 months ago

Describe the bug Scripts to run Pharo Launcher aren't executable by default: pharo-launcher and pharo-launcher-ui

To Reproduce Steps to reproduce the behavior:

  1. Go to directory with deployed launcher package.
  2. Execute e.g.: ./pharo-launcher help
  3. See error: bash: ./pharo-launcher: Permission denied
  4. Same for pharo-launcher-ui

Expected behavior Both executable scripts should be set to be executable by default.

Screenshots If applicable, add screenshots to help explain your problem.

Version information:

Expected development cost Add chmodto set executable flag on both scripts.

demarey commented 10 months ago

After a fresh git clone, both scripts have execution permissions. It looks loke github artifact archive loose these permissions: https://github.com/actions/upload-artifact/issues/38