search

pharo-project / pharo-launcher

Lets you manage your pharo images and download new ones
https://pharo-project.github.io/pharo-launcher/
MIT License
108 stars 46 forks source link

Path to Launcher VM is incorrectly set in execution scripts of Pharo launcher #642

Closed Bajger closed 5 months ago

Bajger commented 5 months ago

Describe the bug Execution scripts pharo-launcher and pharo-launcher-ui has wrong path to launcher vm.

To Reproduce Steps to reproduce the behavior:

  1. Go to directory with unpacked pharo-launcher package
  2. Execute e.g.: ./pharo-launcher help
  3. See error: ./pharo-launcher: line 33: ./pharo-vm/pharo: No such file or directory Reason: Pharo vm is currently ./shared/pharo-vm/pharo

Expected behavior Launcher scripts (UI as well as CLI) points to correct vm path and can be successfully executed.

Version information:

Expected development cost Either vm is moved to pharo-vm (instead of shared/pharo-vm) during packaging. Or scripts are adopted to use ./shared/pharo-vm instead of pharo-vm

demarey commented 5 months ago

yes, it looks like pharo-vm is wrongly put into the shared directory.